fix #14340 #16386
Merged
fix #14340 #16386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ef2c908876e157f07e1dda4c966924d0c00ef9d8.
timotheecour
force-pushed
the
pr_fix_14340
branch
from
124059e
to
af17837
Compare
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14340
note:
from #16168 (comment)
it turns out this wasn't enough, as it'd fail one of the tests I've added in this PR, so the fix is the same as the one that was done in #16168, but with the addition of the reduced test case #14340 (comment) and the reduced case that would fail if we had instead
n.kind == nkClosure