Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #14340 #16386

Merged
merged 4 commits into from
Jan 1, 2021
Merged

fix #14340 #16386

merged 4 commits into from
Jan 1, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Dec 18, 2020

fix #14340

note:
from #16168 (comment)

Instead check for n.kind == nkClosure or whatever it's named.

it turns out this wasn't enough, as it'd fail one of the tests I've added in this PR, so the fix is the same as the one that was done in #16168, but with the addition of the reduced test case #14340 (comment) and the reduced case that would fail if we had instead n.kind == nkClosure

This reverts commit ef2c908876e157f07e1dda4c966924d0c00ef9d8.
@timotheecour timotheecour marked this pull request as ready for review December 19, 2020 02:31
@Araq Araq merged commit 0d0e434 into nim-lang:devel Jan 1, 2021
@timotheecour timotheecour deleted the pr_fix_14340 branch January 1, 2021 23:02
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

myfuns[runtimeIndex]() gives FieldError when myfuns is a CT array of closures
2 participants