fix #16265; fix #13999 (HCR on OSX); cgen now does not line wrap string litterals #16329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
This was referenced Dec 12, 2020
…h, in combination with other hacks, caused a really obscure looking bug
timotheecour
force-pushed
the
pr_cgen_nowrap_strings
branch
from
491b46e
to
3848efd
Compare
|
I don't like long string literals when I have to look at the C code so some compromise would be nice to have but of course a bugfix is hard to argue about. |
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…t line wrap string litterals (nim-lang#16329) * fix nim-lang#16265: cgen now does not line wrap string litterals which, in combination with other hacks, caused a really obscure looking bug * fix nim-lang#13999; nimhcr_integration.nim now works for osx * try to make appveyor CI disappear * disable openbsd + add diagnostic for openbsd * enable for openbsd * PTEMP * re-disable openbsd
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…t line wrap string litterals (nim-lang#16329) * fix nim-lang#16265: cgen now does not line wrap string litterals which, in combination with other hacks, caused a really obscure looking bug * fix nim-lang#13999; nimhcr_integration.nim now works for osx * try to make appveyor CI disappear * disable openbsd + add diagnostic for openbsd * enable for openbsd * PTEMP * re-disable openbsd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nimcachedir.len#16265When 2 hacks interact badly you get those kind of bugs...
This was painful to debug...