experimental/diff: move isMainModule block to tests/stdlib/tdiff.nim #16172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_isMainModule_migrate_diff
branch
from
df765d8
to
de15bdd
Compare
|
Yeah, I will clean |
ringabout
reviewed
Nov 28, 2020
|
The rest looks good to me. |
ringabout
approved these changes
Nov 28, 2020
|
This module should be moved out of that experimental folder that only exists for it, |
that would require improving API first eg newDiffData => initDiffData
sms => shortestMiddleSnake
# and code cleanups eg:
# Debug.Write(0, "sms", "extend reverse path " + k.ToString())
=>
when defined(nimDiffDebug): ...
it's doable after that |
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view diff with:
git show --color-moved --color-moved-ws=ignore-all-space HEADCI failure unrelated: #16169