Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonutils: support cstring (including as Table key); improve docs #16062

Merged
merged 5 commits into from
Mar 31, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Nov 20, 2020

That's exactly why I was wondering. Seems like it should work out of the box which is why I was surprised.

  • un-disable a test that now works

future work

@juancarlospaco
Copy link
Collaborator

Crossreference cstrutils.

@timotheecour
Copy link
Member Author

Crossreference cstrutils.

not necessarily opposed to it, but where and how ? not obvious how they'd relate

changelog.md Outdated Show resolved Hide resolved
lib/std/jsonutils.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 9b67e5c into nim-lang:devel Mar 31, 2021
@timotheecour timotheecour deleted the pr_jsonutils_table_docs branch March 31, 2021 16:58
@timotheecour timotheecour added the TODO: followup needed remove tag once fixed or tracked elsewhere label Mar 31, 2021
@metagn metagn added TODO: followup needed remove tag once fixed or tracked elsewhere and removed TODO: followup needed remove tag once fixed or tracked elsewhere labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: followup needed remove tag once fixed or tracked elsewhere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants