fix #15958 #15970
Merged
fix #15958 #15970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Nov 14, 2020
compiler/ccgtypes.nim
Outdated
| @@ -282,7 +282,7 @@ proc ccgIntroducedPtr(conf: ConfigRef; s: PSym, retType: PType): bool = | |||
| result = false | |||
| # first parameter and return type is 'lent T'? --> use pass by pointer | |||
| if s.position == 0 and retType != nil and retType.kind == tyLent: | |||
| result = pt.kind != tyVar | |||
| result = pt.kind notin {tyVar, tyArray} | |||
There was a problem hiding this comment.
But C arrays are pointers already, why would the C code generator introduce another indirection in this case?
There was a problem hiding this comment.
This fix actually removes double pointer
There was a problem hiding this comment.
But then what about tyOpenArray, tyVarargs (and maybe tySequence)?
There was a problem hiding this comment.
Yes, you are right tyOpenArray, tyVarargs also need this fix. Seq is fine.
Added tests to cover tyOpenArray, tyVarargs to PR
There was a problem hiding this comment.
Also, big sets are mapped to C arrays... :-)
There was a problem hiding this comment.
Yes, they are and they need the fix. Added big sets as well :)
|
ready for review |
narimiran
pushed a commit
that referenced
this pull request
Nov 20, 2020
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Nov 20, 2020
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Nov 20, 2020
cooldome
pushed a commit
that referenced
this pull request
Nov 20, 2020
ringabout
pushed a commit
to ringabout/Nim
that referenced
this pull request
Nov 25, 2020
* followup nim-lang#15970 strenghten regression tests * _
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* fix nim-lang#15958 * also cover openArray and VarArgs * more tests * cover even more types * cover even more types * Trigger build * Trigger build * cover sets passed as arrays
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* followup nim-lang#15970 strenghten regression tests * _
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* fix nim-lang#15958 * also cover openArray and VarArgs * more tests * cover even more types * cover even more types * Trigger build * Trigger build * cover sets passed as arrays
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* followup nim-lang#15970 strenghten regression tests * _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15958