Add strutils.indentation and make unindent use it #15264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clyybber
force-pushed
the
libindentation
branch
from
4c5a84f
to
deae2c4
Compare
dom96
reviewed
Sep 4, 2020
Clyybber
force-pushed
the
libindentation
branch
from
1e2d499
to
deae2c4
Compare
Clyybber
force-pushed
the
libindentation
branch
4 times, most recently
from
808781c
to
76e7b9b
Compare
Clyybber
force-pushed
the
libindentation
branch
from
6c7a4f7
to
542980b
Compare
Clyybber
force-pushed
the
libindentation
branch
from
a0645a3
to
5dfc1a8
Compare
ee7
added a commit
to ee7/Nim
that referenced
this pull request
Nov 10, 2020
The `dedent` and `unindent` links were introduced by commit d67c5cb (nim-lang#15264).
ringabout
pushed a commit
that referenced
this pull request
Nov 11, 2020
narimiran
pushed a commit
that referenced
this pull request
Nov 16, 2020
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Jan 6, 2021
The `dedent` and `unindent` links were introduced by commit d67c5cb (nim-lang#15264).
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* Add strutils.indentation and make unindent use it * Code style * Fix bootstrapping * Improve wording * Fix test * Introduce without breaking change * Fix * Reduce diff * Fix docs link * Add since annotation * Update changelog
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
The `dedent` and `unindent` links were introduced by commit d67c5cb (nim-lang#15264).
irdassis
pushed a commit
to irdassis/Nim
that referenced
this pull request
Mar 16, 2021
The `dedent` and `unindent` links were introduced by commit d67c5cb (nim-lang#15264).
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
The `dedent` and `unindent` links were introduced by commit d67c5cb (nim-lang#15264).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nim-lang/RFCs#161
Closes #11975
Closes #15263 , this PR is an alternative to #15263, main difference is indentation beeing a seperate proc and the loop determining the indentation of a line exiting early if the indentation is greater than or equal to the minimum indentation of the already processed lines.