Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward declaration issues in template/macro context #15091

Merged
merged 11 commits into from
Jul 29, 2020

Conversation

Clyybber
Copy link
Contributor

@Clyybber Clyybber commented Jul 27, 2020

Fixes #15075
Fixes #13484

compiler/evaltempl.nim Outdated Show resolved Hide resolved
@Clyybber Clyybber requested a review from Araq July 29, 2020 12:26
@Araq Araq merged commit 2629d61 into nim-lang:devel Jul 29, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
)

* Fix forward declaration issues in template/macro context

* Correct forward declaration resolving for overloads

* Remove old dead code

* WIP consistent gensym ids

* Minimize diff

* Remove obsoleted hack

* Add templInstCounter to give unique IDs to template instantiations

* Remove obsoleted code

* Eh, init in myOpen, not myProcess...

* Remove optNimV019

* Add testcase for nim-lang#13484
@timotheecour
Copy link
Member

timotheecour commented Feb 25, 2021

this causes a regression: #15526 (and same/similar #17162)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants