Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #13848: make var result work with nim cpp #13959

Merged
merged 2 commits into from
Apr 13, 2020
Merged

fix #13848: make var result work with nim cpp #13959

merged 2 commits into from
Apr 13, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 12, 2020 •
edited
Loading

@timotheecour
Copy link
Member Author

PTAL

@Araq Araq merged commit 814f150 into nim-lang:devel Apr 13, 2020
@krux02
Copy link
Contributor

krux02 commented Apr 13, 2020

Thanks for the fix. But what does PTAL mean?

@ghost
Copy link

ghost commented Apr 13, 2020 •
edited by ghost
Loading

Thanks for the fix. But what does PTAL mean?

@krux02
"Please take another look"

@timotheecour
Copy link
Member Author

timotheecour commented Apr 13, 2020 •
edited
Loading

Thanks for the fix. But what does PTAL mean?

explained here:

#11824 (comment)

@timotheecour timotheecour deleted the pr_fix_13848 branch April 13, 2020 20:35
@timotheecour timotheecour mentioned this pull request Apr 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

var return type for proc doesn't work at c++ backend
3 participants
@timotheecour @krux02 @Araq