Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the example in parseutils and make it auto-checking #13230

Closed
wants to merge 1 commit into from

Conversation

kaushalmodi
Copy link
Contributor

Reviving the PR originally created by @albmoron in #13227. If the OP brings back their PR, this can be closed.

/cc @narimiran

@kaushalmodi
Copy link
Contributor Author

@narimiran @albmoron

Also I was saying is that you can have auto-checking examples in doc strings and have the docs look pretty.

This PR renders this:

image

@timotheecour
Copy link
Member

regarding @narimiran 's comment #13227 (comment) :
commit be8d685 was actually runnning against
#9227 ; if we fix this issue, then we can use runnableExamples pretty much everywhere a doc string was previously preffered

@narimiran
Copy link
Member

Although this PR might be objectively better than #13231, we must also take into an account the social aspect - that PR is their first-time contribution to the Nim codebase, and I would feel bad rejecting it based on some nit-picking.

@narimiran narimiran closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants