Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C backend] make let variables const #12824

Closed
wants to merge 2 commits into from
Closed

[C backend] make let variables const #12824

wants to merge 2 commits into from

Conversation

foldl
Copy link
Contributor

@foldl foldl commented Dec 6, 2019

This is the missing bit of PR #12799, and fixes issue #12216.

@foldl foldl changed the title [C backend] add const for let [C backend] make let variables const Dec 7, 2019
@timotheecour timotheecour mentioned this pull request Dec 8, 2019
Closed
@foldl foldl mentioned this pull request Dec 9, 2019
Merged
@foldl
Copy link
Contributor Author

foldl commented Dec 9, 2019

Issues for this PR: for $$ (and many other functions), the input parameter of the generated C function
need to have a const qualifier. Without this, compiler may complain on type mismatch.

@Araq
Copy link
Member

Araq commented Dec 10, 2019

There is a much less intrusive change that does the same, stay tuned.

@foldl
Copy link
Contributor Author

foldl commented Dec 10, 2019

A better solution in #12870

@foldl foldl closed this Dec 10, 2019
@foldl foldl deleted the add_const_for_let branch December 10, 2019 10:14
@foldl foldl restored the add_const_for_let branch April 21, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foldl @Araq