move cookies and cgi to graveyard #10604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated appveyor fail. Don't want to re-run everything since our queue is getting too large and too slow. |
Araq
reviewed
Feb 9, 2019
| @@ -463,6 +471,107 @@ proc `$`*(u: Uri): string = | |||
| result.add("#") | |||
| result.add(u.anchor) | |||
|
|
|||
|
|
|||
| proc cgiError*(msg: string) {.noreturn.} = | |||
|
I don't like it at all, we should keep these modules in the stdlib if they are used and reasonably free of issues. They don't cost us much maintainance. |
|
Ok, then I'm closing #7810 and putting "won't fix" label there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes PR #9360, and closes #7810.