-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nre to stdlib #2818
Add nre to stdlib #2818
Conversation
It makes the rest of the implementation more complicated and is confusing anyway. The user expects a 1:1 mapping between a match and a name
This reverts commit f692042.
pcre_study can return nil and still succeed The indicator of failure is a non-nil error message
👍 for following Nimble conventions on hiding your implementation's private modules :) |
Where are we with this? |
@flaviut ping. ready for merging? |
Yep, it is!
|
Well there is a conflict. |
* 'devel' of https://github.com/Araq/Nim: Fix #964, fix #1384 Don't inspect typedescs
155 commits? Just for a single new module? |
Wouldn't it be worth to squash these down? |
This contains the complete commit history of nre. That means that people
|
@dom96 What are more commits gonna cost you? A longer git bisect? |
Alright, fine. Another thing: wouldn't it make more sense to keep |
I'd even say breakage is likely. I haven't properly tested that one. Maybe backwards compatibility is worth more than correctness. |
Well it's weird to deprecate and "fix" re at the same time. I say: Don't touch 're' if it's deprecated anyway. |
This reverts commit dc60a51.
Sorry about the delay, I missed the email notification. I've reverted that commit. |
Fixes #2511