Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlas overwrites user files #18750

Closed
timotheecour opened this issue Aug 26, 2021 · 1 comment
Closed

atlas overwrites user files #18750

timotheecour opened this issue Aug 26, 2021 · 1 comment

Comments

@timotheecour
Copy link
Member

timotheecour commented Aug 26, 2021

Example

cd $dir
git clone https://github.com/nim-lang/Nim
cd Nim
sh build_all.sh
ls ..
Nim
bin/nim c -r tools/atlas/atlas.nim clone https://github.com/disruptek/balls
ls ..

Current Output

it generates directories outside of source tree

Nim             balls           grok            nim-bytes2human npeg            packages        sync            testes          ups

and in fact in my use case that prompted this issue, it affected and modified existing files I had in Nim/.. as that directory already contained some cloned packages.

Expected Output

it should generate directories self-contained within source tree:

Nim

possibly under: Nim/.atlas, similar to node_modules/

rationale: things should be kept self contained, so you won't interfere with other local installations of nim (i have more than 1 nim folder for development purposes, branches don't solve everything).

Additional Information

1.5.1 98f7254

see also #18751

@Araq
Copy link
Member

Araq commented Aug 29, 2021

Works as documented.

@Araq Araq closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants