Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Invalid codegen #12672

Closed
dawkot opened this issue Nov 16, 2019 · 1 comment · Fixed by #14158
Closed

[JS] Invalid codegen #12672

dawkot opened this issue Nov 16, 2019 · 1 comment · Fixed by #14158

Comments

@dawkot
Copy link

dawkot commented Nov 16, 2019

Example

proc foo =
  var x: seq[seq[int]]
  for row in x.mitems:
    let i = 1
    inc row[i-1]

foo()

Current Output

Uncaught SyntaxError: Invalid left-hand side in assignment

(Tmp4 = row_42215[row_42215_Idx][chckIndx(subInt(i_42217, 1), 0, row_42215[row_42215_Idx].length+0-1)-0], Tmp4) = addInt(Tmp4, 1);

Expected Output

No errors

Additional Information

$ nim -v
Nim Compiler Version 1.0.2
@metagn
Copy link
Collaborator

metagn commented Apr 26, 2020

Reduces to

var x: seq[seq[int]]
let i = 1
inc x[0][i-1]

So iterators label can be removed.

Araq pushed a commit that referenced this issue Apr 29, 2020
* many bugfixes for js

fixes #12672, fixes #14153, closes #14123, closes #11331, fixes #11783, fixes #13966, fixes #14087, fixes #14117, closes #12256.

mostly fixes the fact that it was allowed to assign to newly created temp variables. additionally attempts to get rid of null initialized seqs/strings (though they might pop up here and there); this simplifies a lot of things and makes code size smaller. even if null seqs/strings pop up here and there it's still better than all those bugs existing.

* formatting fixes

* CI fixes

* more CI fixes
EchoPouet pushed a commit to EchoPouet/Nim that referenced this issue Jun 13, 2020
* many bugfixes for js

fixes nim-lang#12672, fixes nim-lang#14153, closes nim-lang#14123, closes nim-lang#11331, fixes nim-lang#11783, fixes nim-lang#13966, fixes nim-lang#14087, fixes nim-lang#14117, closes nim-lang#12256.

mostly fixes the fact that it was allowed to assign to newly created temp variables. additionally attempts to get rid of null initialized seqs/strings (though they might pop up here and there); this simplifies a lot of things and makes code size smaller. even if null seqs/strings pop up here and there it's still better than all those bugs existing.

* formatting fixes

* CI fixes

* more CI fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants