enforce void for nkWhileStmt [backport: 2.0] (#21170)

enforce void for nkWhileStmt (cherry picked from commit 9323cb7)
nim-lang · Apr 26, 2023 · 0fc1b79 · 0fc1b79
1 parent 8155b8d
commit 0fc1b79
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/compiler/semstmts.nim b/compiler/semstmts.nim
@@ -100,7 +100,6 @@ proc semWhile(c: PContext, n: PNode; flags: TExprFlags): PNode =
     result.typ = n[1].typ
   elif implicitlyDiscardable(n[1]):
     result[1].typ = c.enforceVoidContext
-    result.typ = c.enforceVoidContext
 
 proc semProc(c: PContext, n: PNode): PNode
 

diff --git a/tests/discard/tdiscardable.nim b/tests/discard/tdiscardable.nim
@@ -99,3 +99,14 @@ block: # bug #13583
     let t = test
     doAssert t() == 12
 
+block:
+  proc bar(): string {.discardable.} =
+    "15"
+
+  proc foo(): int =
+    while true:
+      raise newException(ValueError, "check")
+    12
+
+  doAssertRaises(ValueError):
+    doAssert foo() == 12