Unable to add or remove "Restricted To" users - possible OAuth interaction

[jhumphries]

Unsure exactly the full thread of cause, but discovered a case where attempting to add a user to the "restricted to" list for an item writes the user Id to the DB entry, but then fails to display the user in future loads on the front end, and blocks ay future edits (though not deletes) to the record.

It may be related to the creation of users via oAuth, but is directly related to the otp functionality. We do not have any otp functionality active, and out otp_items table is empty. that means that this line always returns 0 rows,

TeamPass/sources/items.queries.php

Line 3173 in fae22cd

INNER JOIN ' . prefixTable('items_otp') . ' AS o ON (o.item_id = i.id)

making the FE render here:

TeamPass/pages/items.js.php

Line 5466 in fae22cd

$.each(store.get('teampassItem').id_restricted_to, function(i, value) {

bomb out because there are entries in the store.get (from the db table) but not in the data.users_list (joined against otp table).

Not sure if there are additional repurcussions at this time, but current recommended fix that has been deployed is to modify the join on

TeamPass/sources/items.queries.php

Line 3173 in fae22cd

INNER JOIN ' . prefixTable('items_otp') . ' AS o ON (o.item_id = i.id)

from INNER to LEFT.