Skip to content

Commit

Permalink
renumber regions in the generator interior
Browse files Browse the repository at this point in the history
  • Loading branch information
nikomatsakis committed Jan 11, 2018
1 parent bf02c57 commit d201e83
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 1 deletion.
17 changes: 16 additions & 1 deletion src/librustc_mir/borrow_check/nll/renumber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

use rustc::ty::subst::Substs;
use rustc::ty::{self, ClosureSubsts, Ty, TypeFoldable};
use rustc::ty::{self, ClosureSubsts, GeneratorInterior, Ty, TypeFoldable};
use rustc::mir::{BasicBlock, Location, Mir, Statement, StatementKind};
use rustc::mir::visit::{MutVisitor, TyContext};
use rustc::infer::{InferCtxt, NLLRegionVariableOrigin};
Expand Down Expand Up @@ -90,6 +90,21 @@ impl<'a, 'gcx, 'tcx> MutVisitor<'tcx> for NLLVisitor<'a, 'gcx, 'tcx> {
*constant = self.renumber_regions(ty_context, &*constant);
}

fn visit_generator_interior(&mut self,
interior: &mut GeneratorInterior<'tcx>,
location: Location) {
debug!(
"visit_generator_interior(interior={:?}, location={:?})",
interior,
location,
);

let ty_context = TyContext::Location(location);
*interior = self.renumber_regions(ty_context, interior);

debug!("visit_generator_interior: interior={:?}", interior);
}

fn visit_closure_substs(&mut self, substs: &mut ClosureSubsts<'tcx>, location: Location) {
debug!(
"visit_closure_substs(substs={:?}, location={:?})",
Expand Down
38 changes: 38 additions & 0 deletions src/test/ui/nll/generator-distinct-lifetime.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(generators, nll)]

// Test for issue #47189. Here, both `s` and `t` are live for the
// generator's lifetime, but within the generator they have distinct
// lifetimes.
//
// Currently, we accept this code (with NLL enabled) since `x` is only
// borrowed once at a time -- though whether we should is not entirely
// obvious to me (the borrows are live over a yield, but then they are
// re-borrowing borrowed content, etc). Maybe I just haven't had
// enough coffee today, but I'm not entirely sure at this moment what
// effect a `suspend` should have on existing borrows. -nmatsakis

fn foo(x: &mut u32) {
move || {
let s = &mut *x;
yield;
*s += 1;

let t = &mut *x;
yield;
*t += 1;
};
}

fn main() {
foo(&mut 0);
}

0 comments on commit d201e83

Please sign in to comment.