Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isPresent command to new Element API. #4216

Merged

Conversation

dikwickley
Copy link
Contributor

@dikwickley dikwickley commented Jun 2, 2024

Fixes: dikwickley/gsoc24#2

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

The isPresent command was quite tricky as there were few edge cases we had to solve.
The main one being when the element in not present, we don't want to show the Timeout Error if there is a isPresent command chained (which should ideally return false).

I solved this by checking if the next sibling of a find command is an elementIsPresent command. It still takes 5 seconds to try to resolve the element.

If this approach looks good, I can add some tests for this too.

Sanity for elements that are not present:
Screenshot 2024-06-03 at 1 24 56 AM

  • Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Copy link

github-actions bot commented Jun 2, 2024

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@pujagani
Copy link
Member

pujagani commented Jun 4, 2024

There are some failing tests. Not sure if it is due to the changes made here. Can you help take a look? Thank you!

@dikwickley
Copy link
Contributor Author

@pujagani yes, fixed those. There was a missing check for outofbounds index.

@AutomatedTester
Copy link
Member

I think the test that is failing is flakey.

I can't see a test for this change can we add one?

@dikwickley
Copy link
Contributor Author

@garg3133 @AutomatedTester ready for review!

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted a few reviews below. Otherwise, looks good!

lib/api/web-element/scoped-element.js Outdated Show resolved Hide resolved
lib/api/web-element/scoped-element.js Outdated Show resolved Hide resolved
lib/transport/selenium-webdriver/method-mappings.js Outdated Show resolved Hide resolved
@garg3133
Copy link
Member

@dikwickley Can you please fix this PR and remove all the unnecessary changes from here? The file changes have gone up to 90 files here.

@dikwickley dikwickley force-pushed the issue/4060-add-ispresent-command branch from 8c95d8c to 66faef3 Compare August 12, 2024 12:52
@garg3133 garg3133 changed the title Add isPresent command. Add isPresent command to new Element API. Aug 12, 2024
@garg3133 garg3133 merged commit 3a83dda into nightwatchjs:main Aug 12, 2024
17 checks passed
dikwickley added a commit to dikwickley/nightwatch that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Missing Capablities
4 participants