Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test not aborting when waitFor commands used with async/await. #4196

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix test not aborting when waitFor commands used with async/await. #4196

merged 1 commit into from
May 5, 2024

Conversation

garg3133
Copy link
Member

Right now, the waitFor commands (like waitForElementVisible) when used with async/await syntax do not abort the test on failure, even when abortOnFailure is set to true.

This PR fixes that by rejecting the command node upon failure when abortOnFailure is set to true, and thus aborting the test.

The implementation around this was merged recently in #4161.

@github-actions GitHub Actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@garg3133 garg3133 merged commit 45ca79e into nightwatchjs:main May 5, 2024
17 checks passed
@garg3133 garg3133 deleted the fix-waitFor-abort branch May 5, 2024 17:55
dikwickley pushed a commit to dikwickley/nightwatch that referenced this pull request Oct 15, 2024
@garg3133 @dikwickley
Fix test not aborting when waitFor commands used with async/await. (n…
6be078e 
…ightwatchjs#4196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garg3133