-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added .attr()
and .attribute()
as an alias for .getAttribute()
command.
#4172
Merged
garg3133
merged 7 commits into
nightwatchjs:main
from
Ayush-Vish:issue/4170/add-aliases-for-getAttribute
Apr 19, 2024
Merged
feat: Added .attr()
and .attribute()
as an alias for .getAttribute()
command.
#4172
garg3133
merged 7 commits into
nightwatchjs:main
from
Ayush-Vish:issue/4170/add-aliases-for-getAttribute
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayush-Vish
changed the title
feat: Added aliases for getAttribute Command
feat: Added aliases for Apr 7, 2024
getAttribute
Command
Ayush-Vish
changed the title
feat: Added aliases for
feat: Added Apr 18, 2024
getAttribute
Command.attr()
and .attribute()
aliases for .getAttribute()
.
garg3133
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the merge conflict as well.
Done in 3474855 |
Ayush-Vish
changed the title
feat: Added
feat: Added Apr 18, 2024
.attr()
and .attribute()
aliases for .getAttribute()
..attr()
and .attribute()
as an alias for .getAttribute()
command.
gravityvi
approved these changes
Apr 19, 2024
garg3133
reviewed
Apr 19, 2024
garg3133
approved these changes
Apr 19, 2024
dikwickley
pushed a commit
to dikwickley/nightwatch
that referenced
this pull request
Oct 15, 2024
…nd. (nightwatchjs#4172) Co-authored-by: Priyansh Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4170
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
examples/tests
directory of the project) and running them.ecosia.js
andduckDuckGo.js
are good examples to work with.features/my-new-feature
orissue/123-my-bugfix
);