Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4078 - throwing NoSuchElementError when .find() command fails. #4102

Closed

Conversation

Ayush-Vish
Copy link
Contributor

@Ayush-Vish Ayush-Vish commented Mar 7, 2024

Fixes #4078

Uploading 2024-03-07 23-13-59.mp4…

  • [.] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • [.] If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • [] Do not include changes that are not related to the issue at hand;
  • [.] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • [.] Always add unit tests - PRs without tests are most of the times ignored.

@Ayush-Vish Ayush-Vish marked this pull request as draft March 7, 2024 18:06
@Ayush-Vish Ayush-Vish marked this pull request as ready for review March 10, 2024 06:24
@Ayush-Vish Ayush-Vish marked this pull request as draft March 10, 2024 06:24
@Ayush-Vish Ayush-Vish marked this pull request as ready for review March 24, 2024 05:15
@Ayush-Vish Ayush-Vish changed the title Fix #4078 - timeout issue on find command Fix #4078 - throwing `NoSuch Apr 18, 2024
@Ayush-Vish Ayush-Vish changed the title Fix #4078 - throwing `NoSuch Fix #4078 - throwing NoSuchElementError when .find() command fails. Apr 18, 2024
@garg3133
Copy link
Member

Fixed in #4193, thanks!

@garg3133 garg3133 closed this Apr 19, 2024
@Ayush-Vish Ayush-Vish deleted the issue/4078/timeout-error-fixed branch April 19, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throwing TimeoutError when chained .find() command fails
2 participants