Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NoSuchElementError error instead of TimeoutError when chained .find() command fails #4080

Conversation

subhajit20
Copy link
Contributor

@subhajit20 subhajit20 commented Mar 2, 2024

… command fails
Added NoSuchElementError instead of TimeoutError when chained .find() command fails
fix - #4078
Screenshot 2024-03-02 at 11 09 57 PM

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Copy link

github-actions bot commented Mar 2, 2024

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@subhajit20
Copy link
Contributor Author

Hey @dikwickley can you please check if this solution would work ?
I am not totally if it does fully fix the problem.

@subhajit20 subhajit20 changed the title Added NoSuchElementError instead of TimeoutError when chained .find()… Added NoSuchElementError error instead of TimeoutError when chained .find() command fails Mar 2, 2024
@subhajit20 subhajit20 marked this pull request as draft March 2, 2024 17:28
@dikwickley
Copy link
Contributor

@subhajit20 can you share the test that you are using to test this?

@subhajit20
Copy link
Contributor Author

subhajit20 commented Mar 3, 2024

@subhajit20 can you share the test that you are using to test this?
Screenshot 2024-03-03 at 12 03 27 PM

is this test meaningful? @dikwickley

@garg3133
Copy link
Member

garg3133 commented Mar 6, 2024

@subhajit20 Sure, but the error message is not what we are looking for.

@subhajit20
Copy link
Contributor Author

subhajit20 commented Mar 7, 2024

@subhajit20 Sure, but the error message is not what we are looking for.

Hey I have changed the error message into this format as I have seen in the issue description you mentioned.
Screenshot 2024-03-07 at 10 14 43 AM

@subhajit20
Copy link
Contributor Author

subhajit20 commented Mar 18, 2024

hey @garg3133 can you review this pr?

@garg3133
Copy link
Member

Fixed in #4193, thanks!

@garg3133 garg3133 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants