Hide password values from raw HTTP logs.

lib/transport/selenium-webdriver/httpclient.js

@@ -37,6 +37,16 @@ module.exports = function(settings, HttpResponse) {
 
     }
 
+    isDataRedacted(data) {
+      for (const value of Object.values(data)) {
+        if (typeof(value) === 'string' && value.includes('\uE000')) {
+          return true;
+        }
+      }
+
+      return false;
+    }
+
     /** @override */
     send(httpRequest) {
       const {method, data, path} = httpRequest;
@@ -52,6 +62,7 @@ module.exports = function(settings, HttpResponse) {
       this.options.data = data;
       this.options.path = path;
       this.options.method = method;
+      this.options.redact = this.isDataRedacted(data);
 
       const request = new HttpRequest(this.options);
 

lib/transport/selenium-webdriver/method-mappings.js

@@ -1,4 +1,4 @@
-const {WebElement, WebDriver, Origin, By, until, Condition} = require('selenium-webdriver');
+const {WebElement, WebDriver, Origin, By, until, Condition, Key} = require('selenium-webdriver');
 const {Locator} = require('../../element');
 const NightwatchLocator = require('../../element/locator-factory.js');
 const {isString} = require('../../utils');
@@ -591,11 +591,12 @@ module.exports = class MethodMappings {
         },
 
         setElementValueRedacted(...args) {
-          // FIXME: redact password in verbose HTTP logs, it's only redacted in the command logs
+          args.push(true); // Passing true for readacting.
+
           return this.methods.session.setElementValue.call(this, ...args);
         },
 
-        async setElementValue(webElementOrId, value) {
+        async setElementValue(webElementOrId, value, redacted = false) {
           if (Array.isArray(value)) {
             value = value.join('');
           } else {
@@ -612,7 +613,12 @@ module.exports = class MethodMappings {
               throw err;
             }
           }
-          await element.sendKeys(value);
+          if (redacted) {
+            // Using Key.NULL as a flag for redacted values.
+            await element.sendKeys(value, Key.NULL);
+          } else {
+            await element.sendKeys(value);
+          }
 
           return null;
         },