Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aliases of find and findElement command #4058

Closed

Conversation

subhajit20
Copy link
Contributor

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

Added aliases of find command
fix - #4057

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@subhajit20 subhajit20 changed the title Added aliases of find command Added aliases of find and findElement command Feb 29, 2024
@subhajit20
Copy link
Contributor Author

Hey @garg3133 can you just review my pr ?
I have only added find command aliases findElement to see if this how other aliases can be added further.

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following commands does not work in TS:

  • browser.element.get()
  • browser.element.findElement()

@subhajit20
Copy link
Contributor Author

The following commands does not work in TS:

  • browser.element.get()
  • browser.element.findElement()

Okay then instead of findElement command get command can be a aliases of find ?

@subhajit20 subhajit20 closed this Mar 1, 2024
@subhajit20 subhajit20 reopened this Mar 1, 2024
@subhajit20
Copy link
Contributor Author

The following commands does not work in TS:

  • browser.element.get()
  • browser.element.findElement()

And all the commands should be under web- elements right like there are similar commands exist on element-folder as well so those should not be a aliases?

@garg3133
Copy link
Member

Both get() and findElement() must be an alias to find() on the .element namespace. And yes, we are only dealing with the commands present in web-elements directory here.

@subhajit20
Copy link
Contributor Author

hey @garg3133 I have added some test inside ecosia.js file.
can you please check and give some feedback on weather any changes are needed or not?

@garg3133
Copy link
Member

Fixed in #4130, thanks!

@garg3133 garg3133 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants