Blacklist for skipping tests or test folders in different environments.

[ozymandias547]

This is a possible feature for ticket #107; It adds the ability to skip tests based upon the following blacklist in the settings.json:

"test_settings" : {
    "default" : {
        ...
        "blacklist" : {
              "files" : ["widgets/file1"],
              "directories" : ["pages", "templates"]
        },
    "env2" : {
        ...
        "blacklist" : {
              "files" : ["widgets/file3"],
              "directories" : ["pages", "registration"]
        }
    }
}

[davidlinse]

i'd vote for exclude or ignore as property name and would prefer the first.
my two cents

~david

[beatfactor]

yeah, I think exclude would be a better name.

[ozymandias547]

Yea, 'exclude' does sound like a better name for it... 'blacklist' is rather vague come to think of it.

Concerning #107 :
"I think it would be more elegant if we can overwrite the src_folders inside a specific test_settings section. How do you feel about this idea? I'm not sure about the term 'blacklist'... "

Would that require that we have a separate folder for every unique set of tests on each environment? We have a large amount of tests on a large amount of environments, and having individual src_folders might get really big. Also, that would break the DRY principle many times. What do you think?

[ozymandias547]

Changed to exclude:

"test_settings" : {
    "default" : {
        ...
        "exclude" : {
              "files" : ["widgets/file1"],
              "directories" : ["pages", "templates"]
        },
    "env2" : {
        ...
        "exclude" : {
              "files" : ["widgets/file3"],
              "directories" : ["pages", "registration"]
        }
    },
    "env3" : {
        ...
        exclude : "all"
}

If you think this is a good idea, could you take a look at line#330 & 331 to see if I'm finding the current test folder correctly?

[beatfactor]

Ok, maybe the src_folders is not such a great idea, so let's forget about that. I think the exclude is a nice feature to have, however I have still some issues with how it's coded. First of all the if lines are very long and could be probably simplified. Also they miss the curly braces, in fact jshint should complain about that.

Secondly, it would be nice if the files and directories could be combined into one array and be specified using glob expressions, like the --filter option. There's already a module included which simplified this.

What do you think? Sorry if I'm being too painstaking here.

[ozymandias547]

I'll look into those changes - still new to your codebase and the patterns you like to follow, so I don't mind :)

[beatfactor]

I've implemented the exclude option in 0.4.9. I did it a bit differently so I couldn't use your pull request, I hope you don't mind too much. Here's how it works:

You can specify an array of folders or patterns to match files, all in the same list:

"exclude" : ["excluded-folder"]

or files:

"exclude" : ["tests/src/files-*", "tests/src/other-files*"]

or combined:

"exclude" : ["tests/src/files-*", "tests/src/exclude-folder"]

[ozymandias547]

That's great! I don't mind at all that you didn't use my PR. You know your code better than anyone. Thanks again for this feature.