Default Timeouts

[haggyj]

Any thoughts on having default timeouts around some of the commands? For example, I find myself littering tests with the same timeout for waitForElementPresent

The below example is fairly simplistic but the default timeout could easily be 5000ms perhaps? Or set as a global?

browser
  .url("https://www.google.com")
  .waitForElementVisible("body", 1000)
  .assert.title("Google")
  .waitForElementVisible("button[name=btnG]", 1000)
  .click("button[name=btnG]")
  .end()

[beatfactor]

Hmm, it could be nice to have something like that. Are you suggesting to make this available as part of the globals object?

[haggyj]

That would seem like a reasonable approach to me - use the global setting unless someone has specified the timeout on the method.

If neither of those are specified we could change the error to have some useful feedback, or going one step further we could pick a reasonable default for people.

My vote would probably be to implement the first piece and then see if we get any more feedback around it....

[beatfactor]

Allowing a global setting to be defined which will be used if no time
parameter is passed can't do any harm. It's just a matter of finding a good
meaningful name for it. Maybe we can come up with a pattern which might be
used in the future for other kind of globals.

On Tue, Apr 8, 2014 at 2:59 PM, Jonathan Haggarty
[email protected]:

That would seem like a reasonable approach to me - use the global setting
unless someone has specified the timeout on the method.

If neither of those are specified we could change the error to have some
useful feedback, or going one step further we could pick a reasonable
default for people.

My vote would probably be to implement the first piece and then see if we
get any more feedback around it....

Reply to this email directly or view it on GitHubhttps://github.com/beatfactor/nightwatch/issues/129#issuecomment-39844128
.

[haggyj]

{ "operationTimeout": 5000 }

or perhaps...

{ 
  "nightwatch": {
    "waitOperationTimeout": 5000 
  }
}

One small issue with the name is that it might be suggestive that the pause command would respect it, whereas it just waits indefinitely (which is fairly useful for debugging)

[beatfactor]

how about waitForConditionTimeout?

On Tue, Apr 8, 2014 at 4:14 PM, Jonathan Haggarty
[email protected]:

{ "operationTimeout": 5000 }

or perhaps...

{
"nightwatch": {
"waitOperationTimeout": 5000
}}

One small issue with the name is that it might be suggestive that the
pause command would respect it, whereas it just waits indefinitely (which
is fairly useful for debugging)

Reply to this email directly or view it on GitHubhttps://github.com/beatfactor/nightwatch/issues/129#issuecomment-39852557
.

[sabind]

Looks like a good idea :)

[LolaYan]

is this default setting called 'waitForConditionTimeout'?

[sparda2]

Would this setting apply for the pages/chai expect command? page.expect.element('@element').to.be.present.after(xxxx)???

[rhuanbarreto]

I'm wondering the same. Is this applicable for expectations?

[beatfactor]

Yes.

…

On Fri, 7 Jun 2019 at 17:30, Rhuan ***@***.***> wrote: I'm wondering the same. Is this applicable for expectations? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#129?email_source=notifications&email_token=AADGNMWFDXBHKVZBK2FRQNLPZJ5ITA5CNFSM4AOCGOK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXGFO6I#issuecomment-499931001>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADGNMUSEYF7GT7XXYIGIBLPZJ5ITANCNFSM4AOCGOKQ> .