Fixed #2975 - expect.element() not present error (#2977)

nightwatchjs · Feb 7, 2022 · ed04684 · ed04684
1 parent a16584c
commit ed04684
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/lib/api/expect/assertions/element/present.js b/lib/api/expect/assertions/element/present.js
@@ -49,14 +49,7 @@ class PresentAssertion extends BaseAssertion {
   }
 
   onResultFailed() {
-    if (this.resultErrorStatus instanceof Error) {
-      this.passed = false;
-      this.actual = 'error while locating the element';
-      this.expected = this.negate ? 'not present' : 'present';
-
-      return;
-    }
-
+    this.expected = this.negate ? 'not present' : 'present';
     this.passed = this.negate;
   }
 

diff --git a/test/src/api/expect/testExpectPresent.js b/test/src/api/expect/testExpectPresent.js
@@ -130,7 +130,7 @@ describe('expect.present', function() {
         assert.strictEqual(expect.assertion.waitForMs, 40);
         assert.strictEqual(expect.assertion.passed, false);
         assert.strictEqual(expect.assertion.expected, 'present');
-        assert.strictEqual(expect.assertion.actual, 'error while locating the element');
+        assert.strictEqual(expect.assertion.actual, 'not present');
         assert.ok(expect.assertion.message.startsWith('Expected element <#weblogin> to be present - element was not found'));
         assert.strictEqual(expect.assertion.messageParts[0], ' - element was not found');
       });
@@ -170,6 +170,28 @@ describe('expect.present', function() {
       });
     });
 
+    it('to not be present if element doesn\'t exist [PASSED]', function() {
+      this.client.api.globals.waitForConditionTimeout = 40;
+      this.client.api.globals.waitForConditionPollInterval = 20;
+
+      Nocks.elementNotFound()
+        .elementNotFound()
+        .elementNotFound();
+
+      let expect = this.client.api.expect.element('#weblogin').to.not.be.present;
+
+      return this.client.start(function() {
+        assert.strictEqual(expect.assertion.selector, '#weblogin');
+        assert.strictEqual(expect.assertion.negate, true);
+        assert.strictEqual(expect.assertion.passed, true);
+        assert.strictEqual(expect.assertion.expected, 'not present');
+        assert.strictEqual(expect.assertion.actual, 'not present');
+        assert.strictEqual(expect.assertion.resultErrorStatus.name, 'NoSuchElementError');
+        assert.ok(expect.assertion.message.startsWith('Expected element <#weblogin> to not be present'));
+        assert.strictEqual(expect.assertion.messageParts.length, 2);
+      });
+    });
+
     it('to be present - xpath via useXpath [PASSED]', function() {
       Nocks.elementFoundXpath();