fix(pi-board): use theme success token for the live indicator (dark-mode) - #4
Merged
Merged
Conversation
…ode) The Program Board's "Live" dot used a hardcoded #16A34A / rgba green, which violates the "no invented colors" guardrail and didn't adapt in dark mode (ADR-0056). Swap it for color.success + color.successTint, which carry proper light/dark variants. Note: an i18n pass on the new strings was considered and dropped — none of the 25 feature screens use the t()/useI18n API (localization is applied only in the shell today), so wrapping just the board would be inconsistent with every neighbouring screen. App-wide i18n adoption is a separate, broader effort. Frontend build, lint and the 72-test suite pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F1g44VLAeYdf3FAoXsXRu7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small consistency fix from the latest gap review.
Fix — hardcoded color on the board's "Live" dot
The Program Board's connection indicator used a raw
#16A34A/rgba(22,163,74,…)green. That violates the "no invented colors" guardrail and doesn't adapt in dark mode (ADR-0056). Swapped forcolor.success+color.successTint, which carry proper light/dark variants.Dropped after verification — i18n
I proposed localizing the new UI strings, but on inspection none of the 25 feature screens use the
t()/useI18nAPI — localization is applied only in the shell today. Wrapping just the board would be inconsistent with every neighbouring screen, so this is out of scope; app-wide i18n adoption is a separate, broader effort.Verification
Frontend
build+eslint+ 72 tests pass locally.Remaining known gaps (need an SDK-equipped env; not in this PR)
PiObjective.IterationIdmigration — also the proper fix for the placement concurrent-write race (per-row writes are naturally safe vs. the current single-JSON-blob read-modify-write).🤖 Generated with Claude Code
https://claude.ai/code/session_01F1g44VLAeYdf3FAoXsXRu7
Generated by Claude Code