Drop setuptools dependency #692
Conversation
|
Thanks @mathiascode. But isn't setuptools the successor to distutils? |
|
That's correct, and distutils will most likely be removed from the standard libraries in a few years. However, since issues like this have occurred recently, and the whole situation is a bit uncertain due to patches by Debian and other distros right now, I'm more inclined to stick with distutils for now, and look into setuptools or completely different build systems when the time is right. |
|
Hmm, I'm not sure what to suggest. On the one had I don't want us to be dependant on a broken tool. On the other I don't think migrating back to a tool that is slated for removal is helpful either. We're not in any rush, so I'm going to leave this open for a week for open discussions and time for you to also think about it. |
|
@mathiascode, can you resolve your conflicts and verify CI? |
|
Done. |
|
Hmm, still breaking on Windows. |
|
Strange, I'll retry at some point tomorrow. |
mathiascode
force-pushed
the
distutils
branch
3 times, most recently
from
08740cc
to
94bac21
Compare
mathiascode
force-pushed
the
distutils
branch
4 times, most recently
from
10c8f05
to
993ed96
Compare
|
Alright, got it sorted out. |
The only reason I opted to use setuptools previously was due to
find_packages. However, thesingle-version-externally-managedoption, which we need to install files to the correct folders on the system, has caused a lot of pain so far, as it's not recognized by pip. Drop the setuptools dependency in favor of distutils, and use our own method of finding the correct packages and package data.Pretty sure the introduction of setuptools also causes an issue where Nicotine+ is installed to /usr/lib/python3.X/dist-packages instead of /usr/lib/python3/dist-packages.
Fixes #531