Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

Can't export settings to file #24

Open
stkb opened this issue Nov 8, 2016 · 9 comments
Open

Can't export settings to file #24

stkb opened this issue Nov 8, 2016 · 9 comments

Comments

@stkb
Copy link

stkb commented Nov 8, 2016

Describe the issue

When trying to export to a file from the "My filters", "My rules" or "Whitelist" tabs in the settings, the download of a file "starts" but the Save/Save as buttons on the download prompt don't work, so the exported file can't be saved.

One or more specific URLs where the issue occurs

ms-browser-extension://uBlockOrigin_rfgc05fqypn62/dashboard.html#whitelist.html

Screenshot in which the issue can be seen

export

Steps for anyone to reproduce the issue

  1. Install a fresh copy of ublock-edge
  2. Go to ublock's settings and the "My filters" tab
    2a. Or the "My rules" tab
    2b. Or the "Whitelist" tab
  3. Click the "Export" button and wait for the download prompt to come up: "What do you want to do with [...].txt"
  4. Try clicking on the Save, Save As or Cancel buttons. None of them do anything. Only the X on the far right will dismiss the prompt.

Your settings

  • Browser/version: Edge 38.14393.0.0
  • uBlock Origin version: Tested on 1.9.17b6-edge, 1.9.17b1-edge, 1.9.15rc0-edge

Works without problem on the Chrome version

Your filter lists

Default

Your custom filters (if any)

None

@nicole-ashley
Copy link
Owner

Thanks for this. Additional info: on Edge build 39.14931.1000.0 (Slow Ring) I don't get the Save/Save As/Cancel option at all; the file opens up directly in Notepad. Which is also not ideal (I think most people would rather being able to save it directly to a file) but it looks like the Edge team may have applied a fix since the latest public release.

@stkb
Copy link
Author

stkb commented Nov 8, 2016

Hmm interesting. Yeah it's also not ideal like that, but if it stays that way then you'll at least be able to save the data.

@stkb
Copy link
Author

stkb commented Nov 10, 2016

Relevant: Edge platform issue #8477778.

BTW, just want to thank you for all your effort in this fork. It's really great to be able to use uBlock-origin in Edge :)

@nicole-ashley
Copy link
Owner

Good spotting, thanks! I think I may be able to figure a workaround, but it's good to see that the core issue is logged and will eventually be fixed.

And thanks, it's as much for me as for everyone else but I'm glad that everyone finds it useful 😄

@nicole-ashley
Copy link
Owner

Update: I've been in contact with Microsoft and they have confirmed again that a fix is on the way. I have tried a few suggested workarounds but none are sufficient. As the current Fast Ring build actually does allow you to download (albeit with a worse experience, auto-saving into a cache folder and opening that file in the default text viewer) I'm going to leave that as is until the Edge fix comes.

@CoolCmd
Copy link

CoolCmd commented Dec 27, 2017

@nikrolls, your fix does not work in Edge 16 (FCU). Buttons 'back up to file' and 'export' do nothing.

And M$ added "Won’t fix" label to issue 8178877. LOL

@nicole-ashley
Copy link
Owner

Unfortunately this is completely broken due to an Edge issue. Even though we route the download to the foreground page it still doesn't work ☹

I'll contact Microsoft to see if there's a workaround. If not, I'll see if there's a way I can detect the issue and pop a message to inform the user that it's not working in Edge for now.

@CoolCmd
Copy link

CoolCmd commented Feb 7, 2018

@nikrolls, in my extension I open the window (window.open) on "safe" site and pass the exported data through location.search. manifest.json contains a content script which runs on this address and saves the passed data. See the file bug8178877.js in my extension.

This method is not ideal but much better than nothing. You can use this address for content script. Or you can create GithubPages (and as bonus set the desired "favicon").

@AmineI
Copy link

AmineI commented Apr 13, 2019

As this is still an issue, is there any workaround to manually export the data ? Considering Edge is moving to Chromium anyway, it'd be nice to have a way to copy the settings to the chromium version :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants