Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only necessary rails gem dependencies #88

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

alexeyschepin
Copy link
Contributor

Description

As discussed in #87 it makes sense to keep only necessary rails dependencies. It will allow to use this gem without the whole rails suite

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

Additional Notes

Optional section

Copy link
Collaborator

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the CI logs and I don't see Rails in the result list from bundle install, so this looks good 🙌 !

@iMacTia iMacTia merged commit 4bf99b4 into nicolasblanco:master Jan 21, 2022
@alexeyschepin
Copy link
Contributor Author

@iMacTia great! Thanks for such a quick feedback. Do you know when it could be released?

@iMacTia
Copy link
Collaborator

iMacTia commented Jan 21, 2022

I'd say let's ship it 🚢 !

@iMacTia
Copy link
Collaborator

iMacTia commented Jan 21, 2022

@alexeyschepin there you go! https://rubygems.org/gems/rails_param/versions/1.3.0
It would be great to know if it worked 👍

@alexeyschepin
Copy link
Contributor Author

@iMacTia amazing, it seems to be working just fine

@alexeyschepin alexeyschepin deleted the modify-gem-dependencies branch January 22, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants