Error if reserved message keys are mixed with unreserved keys#320
Merged
nicksnyder merged 11 commits intomainfrom Oct 13, 2024
Merged
Error if reserved message keys are mixed with unreserved keys#320nicksnyder merged 11 commits intomainfrom
nicksnyder merged 11 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 74.90% 75.73% +0.82%
==========================================
Files 20 20
Lines 1634 1677 +43
==========================================
+ Hits 1224 1270 +46
+ Misses 347 344 -3
Partials 63 63 ☔ View full report in Codecov by Sentry. |
|
Hello @nicksnyder - "descr": "{{if .DeliveryTime}}Livraison estimée : {{.DeliveryTime}} jours{{end}}",
+ "descr": {
+ "other": "{{if .DeliveryTime}}Livraison estimée : {{.DeliveryTime}} jours{{end}}",
+ "leftDelim": "<<",
+ "rightDelim": ">>"
+ },I don't fully remember how it all works but it was a workaround to support golang templating How do I fix this problem? UPDATE. Created the issue #357 |
bep
pushed a commit
to gohugoio/go-i18n
that referenced
this pull request
Oct 18, 2025
…yder#320) Makes it an error to provide data that mixes reserved message keys with unreserved ones. Previously the unreserved keys would be ignored, but this caused surprising behavior where if someone added a message that had a key with a reserved word, it would silently break the whole translation file. This change turns that situation into an error. Resolves nicksnyder#209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it an error to provide data that mixes reserved message keys with unreserved ones. Previously the unreserved keys would be ignored, but this caused surprising behavior where if someone added a message that had a key with a reserved word, it would silently break the whole translation file. This change turns that situation into an error.
Resolves #209