Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Previews not working when it jumps to next episode #28

Closed
fallenbagel opened this issue Aug 14, 2022 · 3 comments
Closed

[Bug] Previews not working when it jumps to next episode #28

fallenbagel opened this issue Aug 14, 2022 · 3 comments

Comments

@fallenbagel
Copy link

The previews work perfectly when i explicitly open a specific episode and the previews are shown for that exact same episode but when it finishes playing and jumps to next episode, previews does not appear.

For example, here I opened an item S01E02 (works):
image

But when I open S01E01 and then jump to/let it finish playing and start the next episode (does not work):
image

(Occurs on both web client as well as jmp)

@fallenbagel fallenbagel changed the title Previews not working when it jumps to next episode [Bug] Previews not working when it jumps to next episode Aug 14, 2022
@fallenbagel
Copy link
Author

fallenbagel commented Aug 14, 2022

From my testings, I found that GetBif is not called in subsequent episodes:
S01E02 (opened directly so it got called):
image

S01E02 (after jumping from S01E01 so not directly opened):
image

As you can see from this, GetBif is not called on the subsequent episode when jumped. Gets called when directly opened though

video_2022-08-14_11-26-23.mp4

@nicknsy
Copy link
Owner

nicknsy commented Aug 23, 2022

Yeah Ill try to fix this soon. Looking to rewrite a good bit of the client script

@nicknsy
Copy link
Owner

nicknsy commented Aug 25, 2022

Fixed by f69f784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants