Skip to content

Conversation

@tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Aug 24, 2024

We can't assume that SwiftFormat.exe will work with the Swift runtime installed on the user's machine (if there even is one), so the installer should package the runtime.

Also updates the github workflow to build with Swift 5.10.1 whose installer includes a redistributable.

Verified with a local build + installer build invocation.

@codecov
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (7ce5af4) to head (e602d31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   94.72%   94.69%   -0.03%     
==========================================
  Files          20       20              
  Lines       17978    17978              
==========================================
- Hits        17030    17025       -5     
- Misses        948      953       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicklockwood
Copy link
Owner

Thank you!

@nicklockwood nicklockwood merged commit ea80b65 into nicklockwood:main Aug 25, 2024
@tristanlabelle
Copy link
Contributor Author

This fixes #1775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants