forked from delta-io/delta-kernel-rs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper reading of parquet columns #1
Open
nicklan
wants to merge
15
commits into
make-multi-partitioned-work
Choose a base branch
from
proper_reading_of_parquet_columns
base: make-multi-partitioned-work
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Proper reading of parquet columns #1
nicklan
wants to merge
15
commits into
make-multi-partitioned-work
from
proper_reading_of_parquet_columns
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parition columns + add support for binary and decimal scalars
nicklan
force-pushed
the
proper_reading_of_parquet_columns
branch
from
March 25, 2024 17:53
adae294
to
3c52d08
Compare
nicklan
force-pushed
the
proper_reading_of_parquet_columns
branch
from
March 25, 2024 19:03
f4dfb68
to
498b88e
Compare
Co-authored-by: Ryan Johnson <[email protected]>
- spell indices correctly - add with_schema_opt and use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the scan schema down into the parquet reader and actually use it.
Seeing how this works as a "stacked" PR, so may be odd. Will add more description in the future.