Fix params/path diffing bugs #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rwjblue merged 2 commits into nickiaconis:master from chadhietala:it-never-ends-kill-this-thing-with-fire

Aug 12, 2019

Contributor

chadhietala commented Aug 9, 2019

Before this fix the pivot point would be incorrect for the following case:

visit /profile/1
click /profile/1/view
click /profile/2/view


          Failing test

17edc0d

rwjblue approved these changes

View reviewed changes


          BUGFIX Fix params/path diffing bugs

d7ffa24

chadhietala force-pushed the it-never-ends-kill-this-thing-with-fire branch from 554d87e to d7ffa24 Compare

August 9, 2019 19:50

rwjblue merged commit 66b0916 into nickiaconis:master

rwjblue added the bug label

rwjblue changed the title ~~BUGFIX Fix params/path diffing bugs~~ Fix params/path diffing bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug