Further improvements in the existing unit test library made #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this change is that the reference to the full .net version of SharpSimpleNLG library removed from SharpSimpleNLGTests and a reference to its .net standard version added.
|
Thanks Arash-Sabet for updating this. Please tell me when it is ready for another NuGet, and I will push it out |
|
You're very welcome. We don't need to roll out a new nuget package because the change is isolated in the test library that has a reference to the core simple nlg library. |
|
Great. I've still got to create a correct .NET Standard NuGet Also, there were 7 tests ported from the original Java that didn't pass in the Java version, so we are matching the upstream source :-) |
|
There are more than 7 tests that don't pass either. Their failure don't seem to have anything to do with the recent upgrade to net standard. That's why I had to turn off tests in appveyor temporarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference to full .net version of SharpSimpleNLG in the unit test library has been replaced by a reference to the .net standard version of the library. Also appveyor's yml file added for CI.