fix(static_file_handler): Support for blank spaces and percent encodi…

Cargo.toml

@@ -31,6 +31,7 @@ serde_json = "1.0"
 time = "0.1"
 typemap = "0.3"
 url = "1.0"
+percent-encoding = "1.0.0"
 
 [dev-dependencies]
 serde_derive = "1.0"

src/lib.rs

@@ -11,6 +11,7 @@ extern crate url;
 extern crate mustache;
 extern crate groupable;
 extern crate modifier;
+extern crate percent_encoding;
 
 #[macro_use] extern crate log;
 #[macro_use] extern crate lazy_static;

src/static_files_handler.rs

@@ -1,6 +1,8 @@
 use std::path::{Path, PathBuf};
 use std::io::ErrorKind::NotFound;
 use std::fs;
+use std::borrow::Cow;
+use std::str::Utf8Error;
 
 use hyper::method::Method::{Get, Head};
 
@@ -45,13 +47,15 @@ impl StaticFilesHandler {
         }
     }
 
-    fn extract_path<'a, D>(&self, req: &'a mut Request<D>) -> Option<&'a str> {
+    fn extract_path<'a, D>(&self, req: &'a mut Request<D>) -> Option<String> {
         req.path_without_query().map(|path| {
-            debug!("{:?} {:?}{:?}", req.origin.method, self.root_path.display(), path);
+            let percent_decoded_path = percent_decode_path(path).unwrap();
+
+            debug!("{:?} {:?}{:?}", req.origin.method, self.root_path.display(), percent_decoded_path);
 
             match path {
-                "/" => "index.html",
-                path => &path[1..],
+                "/" => String::from("index.html"),
+                _path => percent_decoded_path[1..].to_string(),
             }
         })
     }
@@ -92,6 +96,10 @@ fn safe_path<P: AsRef<Path>>(path: P) -> bool {
     })
 }
 
+fn percent_decode_path(path: &str) -> Result<Cow<str>, Utf8Error> {
+    percent_encoding::percent_decode(path.as_bytes()).decode_utf8()
+}
+
 #[test]
 fn bad_paths() {
     let bad_paths = &[
@@ -121,3 +129,18 @@ fn valid_paths() {
         assert!(safe_path(path), "expected {:?} to not be suspicious", path);
     }
 }
+
+#[test]
+fn percent_decoded_paths() {
+    let paths_to_match = &[
+        ("file-without-percent", "file-without-percent"),
+        ("file%20with%20percent", "file with percent"),
+        ("folder%20with%20percent/file", "folder with percent/file"),
+        ("folder%20with%20percent/file%20with%20percent", "folder with percent/file with percent"),
+        ("folder-without-percent/file%20with%20percent", "folder-without-percent/file with percent"),
+    ];
+
+    for &path in paths_to_match {
+        assert_eq!(percent_decode_path(path.0).unwrap(), path.1, "expected {:?} to be decoded to {:?}", path.0, path.1);
+    }
+}