Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild chromatic snapshots on new infrastructure version #2554

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Mar 17, 2025

Pull Request

🤨 Rationale

Chromatic infrastructure was updated and new baselines were auto-accepted but when running a full re-build there are still dirty changes because:

  • Chromatic auto accepted the incorrect version of the unstable fiirefox menu story
  • chat message and chat conversation stories were unstable due to animated spinner usage

👩‍💻 Implementation

  • Disable the chat stories spinner animations
  • Tweak preview.js for a full build
  • Accept the changes as new baselines

🧪 Testing

Rely on CI

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite marked this pull request as ready for review March 17, 2025 19:29
@rajsite rajsite enabled auto-merge (squash) March 17, 2025 19:30
@rajsite rajsite merged commit ee50d53 into main Mar 17, 2025
14 checks passed
@rajsite rajsite deleted the test-chromatic-2 branch March 17, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants