Add support for HS384, HS512, RS384, RS512, and ES384 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XLPhere
reviewed
Feb 23, 2023
| @@ -1,2 +1,2 @@ | |||
| /target | |||
| Cargo.lock | |||
| Cargo.lock | |||
There was a problem hiding this comment.
Is this removal of the newline before EOF intentional?
|
Otherwise this looks useful to me, any chance of this getting merged? @nhynes |
You can also just use my fork if you want, I don't plan on deleting it even after it's merged due to the usage of the fork elsewhere |
nhynes
approved these changes
Feb 28, 2023
This was referenced Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR:
jsonwebtoken::DecodingKeyas they weren't turned into public keys before PEM encodingI can split this into 3 seperate merge requests if needed.