Fix docker build #801
Merged
Fix docker build #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix failing pipline build
The version of Alpine used as the base image here is pinned and the envkey install script has not changed in three years, so it is difficult to see how this broke. However, without installing the sudo package the sudo command in install.sh cannot run and the Dockerfile cannot be built. To ensure that the final image does not change we also remove the sudo package after running the install script.
Avoid errors when building the Dockerfile by: * Creating directories and files that 'poetry install' expects * Adding poetry to the current $PATH
dragon-dxw
reviewed
Aug 23, 2024
| @@ -71,7 +71,9 @@ RUN pip install --no-cache-dir \ | |||
| FROM base AS app | |||
|
|
|||
| # Install envkey-source | |||
| RUN curl -s https://raw.githubusercontent.com/envkey/envkey-source/master/install.sh | bash | |||
| RUN set -ex && apk add --no-cache sudo \ | |||
There was a problem hiding this comment.
Can you set the docker user to root rather than using sudo?
There was a problem hiding this comment.
ah... it probably explicitly invokes sudo... sure.
There was a problem hiding this comment.
We don't call USER at all in this file, so I'd assumed the user is already root (but I didn't check!)
dragon-dxw
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX the broken build that can be seen on #800 and https://github.com/nhsx/nhsx-website/actions/runs/10491953953/job/29062294843?pr=800
docker composewheredocker-composeis not availablesudopackage to installenvkey. The version of Alpine used as the base image here is pinned and the envkey install script has not changed in three years, so it is difficult to see how this broke. However, without installing the sudo package the sudo command in install.sh cannot run and the Dockerfile cannot be built. To ensure that the final image does not change we also remove the sudo package after running the install script.Testing
./script/testand check it runs green../script/serverand check you can see a running site at http://localhost:5000