Set CACHEOPS_DEGRADE_ON_FAILURE to True #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow-up to Incident 152 (and 95).
Currently, the app fails with HTTP 5xx errors if the associated
Redis cache is unreachable or cannot be used.
This commit sets the `CACHEOPS_DEGRADE_ON_FAILURE` environment
variable to be `True`. This env var instructs django-cacheops
to wrap Redis calls in a try/except block and to handle
connection errors and timeout errors gracefully, by writing
a warning to the logs, rather than letting the relevant
exception propagate up the stack.
See:
https://github.com/Suor/django-cacheops#setup
https://github.com/Suor/django-cacheops/blob/master/cacheops/redis.py#L12-L22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up to Incident 152 (and 95).
Currently, the app fails with HTTP 5xx errors if the associated Redis cache is unreachable or cannot be used.
This commit sets the
CACHEOPS_DEGRADE_ON_FAILUREenvironment variable to beTrue. This env var instructs django-cacheops to wrap Redis calls in a try/except block and to handle connection errors and timeout errors gracefully, by writing a warning to the logs, rather than letting the relevant exception propagate up the stack.See:
https://github.com/Suor/django-cacheops#setup
https://github.com/Suor/django-cacheops/blob/master/cacheops/redis.py#L12-L22