Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned icons #922

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Commits on Feb 5, 2024

  1. [ref nhsuk#662] Ensure back link icon is in line with text

    Ensures the back link chevron-left icon is vertically aligned with the
    text at all font sizes.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    5e59254 View commit details
    Browse the repository at this point in the history
  2. [refs nhsuk#662] Align back breadcrumb icon with text

    This ensures that the back breadcrumb chevron icon is
    vertically aligned with the text, even at large font sizes.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1500137 View commit details
    Browse the repository at this point in the history
  3. [refs nhsuk#662] Align action link icon with text

    Ensures that the action link icon is vertically aligned with the text,
    even at large font sizes.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    27bdda6 View commit details
    Browse the repository at this point in the history
  4. [refs nhsuk#662] Align pagination icon with text

    Vertically aligns the pagination icon with the pagination text, even
    with large font sizes. This calculation was determined experimentally by
    manually positioning the icons at a variety of font sizes, and succeeds
    in appearing to vertically align the icon in the majority of cases, with
    only very small font sizes looking slightly out of place. The removal of
    `margin-top: 0` for `media-type: print` does not appear to affect the
    output when printing.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    40a1a07 View commit details
    Browse the repository at this point in the history
  5. Suppress SASS errors with calc

    Use `/ 10px` then `* 8px` rather than `* 0.8px` so that SASS doesn't
    error. Still functionally equivalent.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b27af9b View commit details
    Browse the repository at this point in the history
  6. Align vertical chevron with text in header 'more' btn

    Vertically aligns the chevron icon with th 'more' text in the header
    navigation, when it is visible.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8ac105f View commit details
    Browse the repository at this point in the history
  7. Vertically align radio buttons with text

    Ensures that radio buttons are vertically aligned with the label, even
    with larger font sizes.
    pufferfish101007 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a181108 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Align checkboxes with label

    Ensurees that the chekboxes/ticks are vertically aligned with the label
    text, even with large font sizes.
    pufferfish101007 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    481ef88 View commit details
    Browse the repository at this point in the history
  2. Vertically align do/don't icon with text

    Esnures that tick/cross icon is vertically aligned with text, even at
    large font sizes.
    pufferfish101007 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    98baf39 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Update regression for tick/cross alignment

    Updates the regression equation for the do/don't tick cross, so that the
    backstop tests pass.
    pufferfish101007 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    95d2fd0 View commit details
    Browse the repository at this point in the history
  2. Update checkboxes positioning

    Uses a regression function to position the checkbox & tick, rather than
    always centering it in the middle of the paragraph, so as to pass the
    backstop tests.
    pufferfish101007 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4add7e7 View commit details
    Browse the repository at this point in the history
  3. Adjust pagination icon alignment regression

    Adjusts the pagination icon alignment regression calculation so that the
    backstop tests pass.
    pufferfish101007 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c2597de View commit details
    Browse the repository at this point in the history
  4. Adjust radio button alignment calculation

    Uses a regression based on rem, so as to pass the backstop tests and retain
    some consistency with previous behaviour. This is the saame regression as
    for checkboxes.
    pufferfish101007 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1d48a53 View commit details
    Browse the repository at this point in the history
  5. Add changelog entry

    pufferfish101007 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    656dc84 View commit details
    Browse the repository at this point in the history