-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misaligned icons #922
base: main
Are you sure you want to change the base?
Fix misaligned icons #922
Commits on Feb 5, 2024
-
[ref nhsuk#662] Ensure back link icon is in line with text
Ensures the back link chevron-left icon is vertically aligned with the text at all font sizes.
Configuration menu - View commit details
-
Copy full SHA for 5e59254 - Browse repository at this point
Copy the full SHA 5e59254View commit details -
[refs nhsuk#662] Align back breadcrumb icon with text
This ensures that the back breadcrumb chevron icon is vertically aligned with the text, even at large font sizes.
Configuration menu - View commit details
-
Copy full SHA for 1500137 - Browse repository at this point
Copy the full SHA 1500137View commit details -
[refs nhsuk#662] Align action link icon with text
Ensures that the action link icon is vertically aligned with the text, even at large font sizes.
Configuration menu - View commit details
-
Copy full SHA for 27bdda6 - Browse repository at this point
Copy the full SHA 27bdda6View commit details -
[refs nhsuk#662] Align pagination icon with text
Vertically aligns the pagination icon with the pagination text, even with large font sizes. This calculation was determined experimentally by manually positioning the icons at a variety of font sizes, and succeeds in appearing to vertically align the icon in the majority of cases, with only very small font sizes looking slightly out of place. The removal of `margin-top: 0` for `media-type: print` does not appear to affect the output when printing.
Configuration menu - View commit details
-
Copy full SHA for 40a1a07 - Browse repository at this point
Copy the full SHA 40a1a07View commit details -
Suppress SASS errors with
calc
Use `/ 10px` then `* 8px` rather than `* 0.8px` so that SASS doesn't error. Still functionally equivalent.
Configuration menu - View commit details
-
Copy full SHA for b27af9b - Browse repository at this point
Copy the full SHA b27af9bView commit details -
Align vertical chevron with text in header 'more' btn
Vertically aligns the chevron icon with th 'more' text in the header navigation, when it is visible.
Configuration menu - View commit details
-
Copy full SHA for 8ac105f - Browse repository at this point
Copy the full SHA 8ac105fView commit details -
Vertically align radio buttons with text
Ensures that radio buttons are vertically aligned with the label, even with larger font sizes.
Configuration menu - View commit details
-
Copy full SHA for a181108 - Browse repository at this point
Copy the full SHA a181108View commit details
Commits on Feb 6, 2024
-
Ensurees that the chekboxes/ticks are vertically aligned with the label text, even with large font sizes.
Configuration menu - View commit details
-
Copy full SHA for 481ef88 - Browse repository at this point
Copy the full SHA 481ef88View commit details -
Vertically align do/don't icon with text
Esnures that tick/cross icon is vertically aligned with text, even at large font sizes.
Configuration menu - View commit details
-
Copy full SHA for 98baf39 - Browse repository at this point
Copy the full SHA 98baf39View commit details
Commits on Feb 7, 2024
-
Update regression for tick/cross alignment
Updates the regression equation for the do/don't tick cross, so that the backstop tests pass.
Configuration menu - View commit details
-
Copy full SHA for 95d2fd0 - Browse repository at this point
Copy the full SHA 95d2fd0View commit details -
Uses a regression function to position the checkbox & tick, rather than always centering it in the middle of the paragraph, so as to pass the backstop tests.
Configuration menu - View commit details
-
Copy full SHA for 4add7e7 - Browse repository at this point
Copy the full SHA 4add7e7View commit details -
Adjust pagination icon alignment regression
Adjusts the pagination icon alignment regression calculation so that the backstop tests pass.
Configuration menu - View commit details
-
Copy full SHA for c2597de - Browse repository at this point
Copy the full SHA c2597deView commit details -
Adjust radio button alignment calculation
Uses a regression based on rem, so as to pass the backstop tests and retain some consistency with previous behaviour. This is the saame regression as for checkboxes.
Configuration menu - View commit details
-
Copy full SHA for 1d48a53 - Browse repository at this point
Copy the full SHA 1d48a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 656dc84 - Browse repository at this point
Copy the full SHA 656dc84View commit details