Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header styles so that .nhsuk-header__search-no-nav class is no longer needed #1046

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Oct 9, 2024

Description

(Split out from #1000)

  • Update header styles so that .nhsuk-header__search-no-nav class is no longer needed when the header contains a search field but no navigation
  • Update header Nunjucks template so that it no longer repeats markup for search and navigation

This is not a breaking change 🙂

Checklist

@paulrobertlloyd paulrobertlloyd added header Code improvements Any changes that improve but do not alter the appearance of the site labels Oct 9, 2024
@paulrobertlloyd
Copy link
Contributor Author

Oooh, the backstop regression testing is super helpful! Caught a bug, and also turns out this PR fixes a few other issues:

  • Corrects the bottom padding of the header when there’s search but no navigation
  • Removes the navigation border that was showing when there were no navigation items

That explains some of the updated backstop images. The remaining changes are because:

  • The bottom padding is now equal to the top padding
  • Subtle movement of navigation items because the navigation border is now placed on the top of the navigation list, not the bottom of the header container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvements Any changes that improve but do not alter the appearance of the site header
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant