Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use paragraphs for error messages #1030

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented Sep 24, 2024

Description

Fixes #1029.

I'm unsure if this should be considered a breaking change or not - might be worth a discussion.

Visually there should be no difference.

Before After
Video with span Video with paragraph

Checklist

@anandamaryon1 anandamaryon1 added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) accessibility Accessibility related labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message should use paragraphs rather than spans
2 participants