-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer jumps on hover in Safari #575
Comments
Hi @tblacker7, thanks for opening this issue. I have managed to reproduce this on the NHS website, however the website isn't currently using the latest version of NHS.UK frontend. We're currently in the process of updating the version on the website. Do you have the same issue on the NHS.UK Frontend - Footer with columns example? |
it doesnt show on the footer example in the library. However, it does show on deployed sites using the updated library. 🤔 |
That's no good is it - I'll mark this up to be looked at. It will be most likely in the New Year now. Is a fix something you could attempt Tony? We're always open to new contributors! |
the empty div resolves it, but it just feels plain wrong to add a div inside a ul tag... |
removed the Footer with list columns variant, the HTML class `nhsuk-footer__list--three-columns` and `list` Nunjucks parameter has been removed. The Footer will fallback to the regular footer on Desktop and stay the same on mobile.
removed the Footer with list columns variant, the HTML class `nhsuk-footer__list--three-columns` and `list` Nunjucks parameter has been removed. The Footer will fallback to the regular footer on Desktop and stay the same on mobile.
removed the Footer with list columns variant, the HTML class `nhsuk-footer__list--three-columns` and `list` Nunjucks parameter has been removed. The Footer will fallback to the regular footer on Desktop and stay the same on mobile.
The initial and only reasoning was to make it look a bit tidier but I see no problem in going with the self wrapping one row system. |
removed the Footer with list columns variant, the HTML class `nhsuk-footer__list--three-columns` and `list` Nunjucks parameter has been removed. The Footer will fallback to the regular footer on Desktop and stay the same on mobile.
Bug Report
What is the issue?
Using Safari, if you hover over one of the footer links it jumps around. It makes certain links impossible to click.
What steps are required to reproduce the issue?
To see this in action, using Safari web browser (I am on Mac, have witnessed it also happening on Safari for windows), visit www.nhs.uk. Scroll to bottom of the page. Hover over
accessibility
(ironically). As you hover, it jumps away from the mouse, making it unclickable.Is there anything else you think would be useful in recreating the issue?
There is a workaround. Its a little nasty. before the closing
<ul>
for classnhsuk-footer__list nhsuk-footer__list--three-columns
, after the final<li>
add<div style="height: 10px; width: 100%;"></div>
This appears to force Safari to finish allocation of links to columns.The text was updated successfully, but these errors were encountered: