Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer jumps on hover in Safari #575

Closed
tblacker7 opened this issue Dec 20, 2019 · 6 comments · Fixed by #697
Closed

Footer jumps on hover in Safari #575

tblacker7 opened this issue Dec 20, 2019 · 6 comments · Fixed by #697
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 hours A well understood issue which we expect to take less than a day to resolve footer good first issue Good for newcomers
Milestone

Comments

@tblacker7
Copy link

tblacker7 commented Dec 20, 2019

Bug Report

What is the issue?

Using Safari, if you hover over one of the footer links it jumps around. It makes certain links impossible to click.

What steps are required to reproduce the issue?

To see this in action, using Safari web browser (I am on Mac, have witnessed it also happening on Safari for windows), visit www.nhs.uk. Scroll to bottom of the page. Hover over accessibility (ironically). As you hover, it jumps away from the mouse, making it unclickable.

Is there anything else you think would be useful in recreating the issue?

There is a workaround. Its a little nasty. before the closing <ul> for class nhsuk-footer__list nhsuk-footer__list--three-columns, after the final<li> add <div style="height: 10px; width: 100%;"></div> This appears to force Safari to finish allocation of links to columns.

@chrimesdev chrimesdev added the awaiting triage Needs triaging by team label Dec 20, 2019
@chrimesdev
Copy link
Member

chrimesdev commented Dec 20, 2019

Hi @tblacker7, thanks for opening this issue. I have managed to reproduce this on the NHS website, however the website isn't currently using the latest version of NHS.UK frontend. We're currently in the process of updating the version on the website.

Do you have the same issue on the NHS.UK Frontend - Footer with columns example?

@tblacker7
Copy link
Author

it doesnt show on the footer example in the library. However, it does show on deployed sites using the updated library. 🤔

@chrimesdev
Copy link
Member

chrimesdev commented Dec 20, 2019

That's no good is it - I'll mark this up to be looked at. It will be most likely in the New Year now.

Is a fix something you could attempt Tony? We're always open to new contributors!

@chrimesdev chrimesdev added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 hours A well understood issue which we expect to take less than a day to resolve good first issue Good for newcomers Priority: low and removed awaiting triage Needs triaging by team labels Dec 20, 2019
@tblacker7
Copy link
Author

the empty div resolves it, but it just feels plain wrong to add a div inside a ul tag...

@Fenwick17
Copy link
Contributor

This seems to be an issue with column-count. The intial problem is that when no hover state is applied the 8 links we have are in a 3 2 3 format, which is not expected behaviour. So the hover state is correct, but by default is should be the 3 3 2 you see when hovering.
@AdamChrimes What is the design reasoning behind this layout? Just thinking as column-count isn't supported by every browser (IE things) and Gov as an example just leave theres in a self wrapping one row system.
Screenshot 2020-01-02 at 14 06 09
Going with that route I think would give a more logical looking tab order too.

@chrimesdev chrimesdev added this to the 5.0.0 milestone Jan 13, 2021
chrimesdev added a commit that referenced this issue Jan 27, 2021
removed the Footer with list columns variant, the HTML class
`nhsuk-footer__list--three-columns` and `list` Nunjucks parameter
has been removed.

The Footer will fallback to the regular footer on Desktop and
stay the same on mobile.
chrimesdev added a commit that referenced this issue Jan 27, 2021
removed the Footer with list columns variant, the HTML class
`nhsuk-footer__list--three-columns` and `list` Nunjucks parameter
has been removed.

The Footer will fallback to the regular footer on Desktop and
stay the same on mobile.
chrimesdev added a commit that referenced this issue Jan 27, 2021
removed the Footer with list columns variant, the HTML class
`nhsuk-footer__list--three-columns` and `list` Nunjucks parameter
has been removed.

The Footer will fallback to the regular footer on Desktop and
stay the same on mobile.
@davidhunter08
Copy link
Contributor

The initial and only reasoning was to make it look a bit tidier but I see no problem in going with the self wrapping one row system.

@davidhunter08 davidhunter08 linked a pull request Feb 18, 2021 that will close this issue
3 tasks
chrimesdev added a commit that referenced this issue Feb 19, 2021
removed the Footer with list columns variant, the HTML class
`nhsuk-footer__list--three-columns` and `list` Nunjucks parameter
has been removed.

The Footer will fallback to the regular footer on Desktop and
stay the same on mobile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 hours A well understood issue which we expect to take less than a day to resolve footer good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants