Skip to content

fix: prevent access to the window object in the node (fix #48) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix: prevent access to the window object in the node (fix #48) #49

merged 1 commit into from
Apr 3, 2020

Conversation

heenakwag
Copy link
Member

@heenakwag heenakwag commented Mar 23, 2020 •
edited
Loading

  • Remove the code that accesses to the window object

seonim-ryu
seonim-ryu approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[3/23] 👍

@heenakwag heenakwag merged commit 8e267a7 into master Apr 3, 2020
@heenakwag heenakwag deleted the fix/window-in-nodejs branch April 3, 2020 02:16
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@seonim-ryu seonim-ryu seonim-ryu approved these changes

@jung-han jung-han jung-han approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heenakwag @seonim-ryu @jung-han