Skip to content

Throw for DML on filter #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredericDelaporte merged 2 commits into from
Mar 13, 2019
Merged

Throw for DML on filter #2035

fredericDelaporte merged 2 commits into from
Mar 13, 2019

Conversation

@fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Mar 1, 2019

Backport to 5.0.x, fixes #2020

@fredericDelaporte fredericDelaporte added this to the 5.0.7 milestone Mar 1, 2019
@fredericDelaporte fredericDelaporte force-pushed the ThrowDmlFilterOutOf5.0.x branch from ba111d3 to b830102 Compare March 2, 2019 10:48
@fredericDelaporte fredericDelaporte force-pushed the ThrowDmlFilterOutOf5.0.x branch from 553ad85 to f52b0dc Compare March 10, 2019 16:32
@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Mar 10, 2019

Release commit dropped, since another regression is to be fixed.

@hazzik
Copy link
Member

hazzik commented Mar 13, 2019

Commits has to be reordered.

@fredericDelaporte fredericDelaporte force-pushed the ThrowDmlFilterOutOf5.0.x branch from f52b0dc to 1c474ff Compare March 13, 2019 22:34
@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Mar 13, 2019

Reordered.

hazzik
hazzik approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@hazzik hazzik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge by "Rebase & merge" or manually without merge commit/squash (ff).

@fredericDelaporte fredericDelaporte merged commit 4b51721 into nhibernate:5.0.x Mar 13, 2019
@fredericDelaporte fredericDelaporte deleted the ThrowDmlFilterOutOf5.0.x branch March 13, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hazzik hazzik hazzik approved these changes

Assignees

No one assigned

Labels

r: Fixed t: Fix

Projects

None yet

Milestone

5.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@fredericDelaporte @hazzik @bahusoid