Large entity codes now supplied as decoded int instead of overflowed char #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr81ape
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a bug where some characters such as U+1F602 will overflow when cast from an int (128569) to a
chartype. In the case of U+1F602, this will cause the returned character to be U+F602 instead.This PR adds a check to see if the int value of the
_nextCharacterchar matches_nextCharacterCode, which will be false if an overflow occurs during the cast on line 369 (HtmlLexicalAnalyzer.cs). If so, the_nextCharacterCodeis used withHttpUtility.HtmlDecodeto convert the HTML representation the character (using the character code) into the correct character.