Skip to content

Change syscall result#49

Merged
nh2 merged 2 commits intonh2:masterfrom
tgrez:change-syscall-result
Sep 12, 2019
Merged

Change syscall result#49
nh2 merged 2 commits intonh2:masterfrom
tgrez:change-syscall-result

Conversation

@tgrez
Copy link
Contributor

@tgrez tgrez commented Aug 26, 2019

Verified for 64-bit and 32-bit arch.

What do you think about adding this functionality?


This change is Reviewable

@qrilka
Copy link
Collaborator

qrilka commented Aug 27, 2019

Hi @tgrez
How did you test it on 32bit? I wanted to write a script using nix+qemu at least to check compilation of the project. But I didn't start writing it yet.
I didn't check the PR contents yet - will do it in the evening.

Copy link
Collaborator

@qrilka qrilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a cool addition

@qrilka
Copy link
Collaborator

qrilka commented Aug 27, 2019

@tgrez do you have any specific use case for this feature?

@tgrez
Copy link
Contributor Author

tgrez commented Aug 27, 2019

Thanks!

Yes, I do :) one example can be found in here: https://github.com/tgrez/kafka-producer-idempotence
I'm writing a blog post describing this example and Hatrace in general. If you want I can disclose the preview ;)

The 32-bit verification was done just on bare virtualbox vm.

@qrilka
Copy link
Collaborator

qrilka commented Aug 28, 2019

That's great to see new real life example for hatrace!
Please create a PR adding a link to your blog post to README when it will get published.
Thanks.

@nh2 nh2 merged commit a37ec08 into nh2:master Sep 12, 2019
@nh2
Copy link
Owner

nh2 commented Sep 12, 2019

That works, thanks!

And great post by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments